1

Closed

Prev/Next modification using first state?

description

  1. using VS2005, english verison, v32beta_1.7
  2. made 1-1 changes, save.
  3. using next/prev modification works well
  4. undo the modifications, made some new
  5. the prev/next button going to the first 2 modifcation lines.
FYI: i can use v32beta with v31alpha4 resource files (v32beta: missing satelliteDLL), but with alpha4 this feature works well.

file attachments

Closed Feb 7, 2014 at 6:58 AM by pschraut
Fixed in beta 33, revision 74492.

comments

pschraut wrote Oct 24, 2013 at 5:30 PM

This feature is quite a hack, I didn't really come up with something solid to be honest. I think it is/could be quite useful, if it actually works and as you wrote, it only works sometimes. I didn't figure out why though, need to further investigate and this is on my todo list for a looong time already.

However, the comparision works on the file, not the text displayed in the editor, which can be a bit confusing. If you don't save between point 4 and 5, find next/prev modification is most likely jumping to positions that make no sense.

I didn't catch your last sentence. Did you notice a problem with the resource files?

BuzaL wrote Oct 24, 2013 at 7:08 PM

Hello,

I mentioned in another issue, that i cannot use the new v32beta, cause something SatelliteDLL problem.
So i replaced the resource files (within lang folders) from my v31alpha4.

The comparsion:
I learn I have to save to walk thought the modificationsm but forgot to mention, so I saved it at the end of 4.

Maybe the v31alpha4 and v32beta is close enough to diff and catch why doesn't work.
Im ready to help you with sending logs and/or checking unpublished versions, if you build for me :)

pschraut wrote Oct 24, 2013 at 8:16 PM

Prev/Next modification issue:
I'll take a look at this. I think this is just a bug in my code, shouldn't be too much of a problem to fix.

DLL issue:
That's strange. The satellite dll only contains resources, such as texts and images. Maybe it's related to what Visual Studio version I used to build the dll. I used VS 2010 to build VsTortoise 32 and I probably used either 2005 or 2008 to build v31.

Do you have a newer Visual Studio version to test? It's probably a 2005 problem only, because it's been tested with 2008, 2010, 2012 and 2013 where it works fine so far. If you hadn't wrote you use an english version of Visual Studio I had probably said it's a culture-issue, because I remember bugs that occured only in non-english Visual Studio versions, but should be fixed already.

I can compile the plugin/dll with VS 2008 and post a download link in this ticket, so you could give this one a try. I don't think I still have access to VS 2005.

You could also try to build the resources yourself and see if it works. If you check-out the source code, the resources are located in "VsTortoise\Code\Resources". I only execute the "buildall.cmd" batch file which is also located in the resources directory. This builds all dll's and stores the output in "VsTortoise\Code\bin\svn??" where "??" represents the svn version. The batch file needs to be started from the Visual Studio command prompt (see the "Visual Studio 2008 Command Prompt" shortcut in the resources directory and adjust the path to your 2005 installation).

I also wrote a page about building the satellite dll here: Building the Satellite DLL

BuzaL wrote Oct 25, 2013 at 11:02 AM

Hello,

I've checked on another pc, works with vs2010, but doesn't with vs2005. We are using english (us) version of VSs.
I will give it a try to build the dll, but later.

pschraut wrote Oct 28, 2013 at 8:11 PM

Hi BuzaL, regarding the DLL issue... I just uploaded a version you could test. I did rebuild VsTortoise 32 Beta with Visual Studio 2008. The setup is attached to this issue: https://vstortoise.codeplex.com/workitem/10421
Please let me know if it works for you.

PS: Still need to fix the "prev/next modification" feature though.

wrote Oct 29, 2013 at 8:12 PM

pschraut wrote Oct 29, 2013 at 8:12 PM

Hi BuzaL, the "prev/next modification" problem has been fixed at revision 73949. See changeset http://vstortoise.codeplex.com/SourceControl/changeset/73949

This fix will be included in the next VsTortoise release. You can find vstortoise32beta_issue10418_compiled_with_vs2008_svn17.zip attached to this ticket, please let me know if it works for you too.

BuzaL wrote Oct 30, 2013 at 11:48 AM

the vs2008 build works for me (svn1.7), thanks!
I've tested the prev/next function: if I closed the file, and reopen (after step 4), it using the first changes also.

BuzaL wrote Oct 30, 2013 at 11:49 AM

Sorry cause i response late, but I tried to submit my notes for 2 days.

pschraut wrote Oct 30, 2013 at 3:21 PM

Hi BuzaL, don't worry for the delay. I actually didn't test closing and reopening the same file again. I'll check the code later and see if I can spot the bug and upload a new version when I fixed it.

Thanks for the feedback!

wrote Feb 7, 2014 at 6:58 AM

BuzaL wrote Sep 13, 2014 at 1:43 PM

I have tested the v33beta, works fine, but I've found a strange thing.

If I search for the previous modification and the (fresh, saved) changes not on the screen, it won't scroll to it.
If I scroll the changed area on the screen, the prev will jump to it.
It works for that changes which I made before I've loaded the VS.
The find next works well in these cases.

I have a guess about it: maybe those changes affected which made on the first page of the file.